Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blackshades: 2.5.1 -> 2.5.2 #268475

Closed
wants to merge 1 commit into from
Closed

blackshades: 2.5.1 -> 2.5.2 #268475

wants to merge 1 commit into from

Conversation

McSinyx
Copy link
Member

@McSinyx McSinyx commented Nov 19, 2023

Description of changes

Upstream change log

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from viric November 19, 2023 09:38
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 19, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 10, 2024
wolfgangwalther
wolfgangwalther approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The package has been moved to pkgs/by-name. Please rebase.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024
@McSinyx
Copy link
Member Author

McSinyx commented Dec 28, 2024 via email

@ofborg ofborg bot added 10.rebuild-linux: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 28, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 29, 2024
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 268475

x86_64-linux

❌ 1 package failed to build:
  • blackshades

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Dec 29, 2024 •
edited
Loading

That's zig failing to build:

       last 25 log lines:
       >     note: referenced by compiler_rt.lib(compiler_rt.lib.obj):(.weak.__sinh.default._alloca)
       >     note: referenced by compiler_rt.lib(compiler_rt.lib.obj):(.weak.__sincosh.default._alloca)
       >     note: referenced by compiler_rt.lib(compiler_rt.lib.obj):(.weak.__sincosh.default._alloca)
       >     note: referenced by compiler_rt.lib(compiler_rt.lib.obj):(.weak.__sqrth.default._alloca)
       >     note: referenced by compiler_rt.lib(compiler_rt.lib.obj):(.weak.__tanh.default._alloca)
       >     note: referenced by compiler_rt.lib(compiler_rt.lib.obj):(.weak.__trunch.default._alloca)
       >
       > The following command exited with code 1:
       > /build/source/build/stage3/bin/zig test docgen_tmp/test_noreturn_from_exit.zig -target x86_64-windows --test-no-exec
       > ../doc/langref.html.in:5198:25: error: test failed
       >       {#target_windows#}
       >
       > Generating docgen examples [1872/5411] error: ParseError
       > /build/source/tools/docgen.zig:1864:17: 0x2a4b5f in exec (docgen)
       >                 return error.ChildExitError;
       >                 ^
       > /build/source/tools/docgen.zig:289:5: 0x2bff8e in parseError__anon_6755 (docgen)
       >     return error.ParseError;
       >     ^
       > /build/source/tools/docgen.zig:1585:29: 0x2b7ba6 in genHtml__anon_4818 (docgen)
       >                             return parseError(tokenizer, code.source_token, "test failed", .{});
       >                             ^
       > /build/source/tools/docgen.zig:106:5: 0x2c4268 in main (docgen)
       >     try genHtml(allocator, &tokenizer, &toc, buffered_writer.writer(), zig_exe, opt_zig_lib_dir, do_code_tests);
       >     ^

Can't really test this PR as long as zig is failing.

@McSinyx
Copy link
Member Author

McSinyx commented Dec 30, 2024

Yea, I'll update the upstream package for compatibility with a newer (and cached) Zig version then.

@McSinyx McSinyx closed this Dec 30, 2024
@McSinyx McSinyx deleted the blackshades-2.5.2 branch December 30, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McSinyx @wolfgangwalther @wegank